Skip to content

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Dec 15, 2022

This builds on #11697 and supersedes #11125.

@owen-mc owen-mc requested a review from a team as a code owner December 15, 2022 12:15
@github-actions github-actions bot added the Go label Dec 15, 2022
This is used in all other languages not currently using dataflow type
pruning.
This is used in all other languages not currently using dataflow type
pruning.
@owen-mc owen-mc force-pushed the fix/go-callback-type-stubs-2 branch from 9a3adb8 to 76a3fa8 Compare December 15, 2022 12:24
@owen-mc
Copy link
Contributor Author

owen-mc commented Dec 16, 2022

The performance evaluation doesn't show anything interesting. I will add a change note.

@owen-mc
Copy link
Contributor Author

owen-mc commented Dec 16, 2022

Actually I don't think it needs a change note. These three predicates are all only used in SummaryNodeType, and that isn't currently used in the go library. Fixing the first two allows us to have MaD rows describing data flow into a callback. Fixing the third one allows us to use synthetic global fields in future. So it's more of a "get it working to avoid surprises in the future" thing.

@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Dec 16, 2022
@owen-mc owen-mc merged commit 003edea into github:main Dec 16, 2022
@owen-mc owen-mc deleted the fix/go-callback-type-stubs-2 branch December 16, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants