Swift: Fix RemoteFlowSource performance issue. #11708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atorralba
approved these changes
Dec 15, 2022
|
Isn't that always the way. |
|
DCA LGTM (analysis and tuple sums improvements on multiple projects, though its difficult to tell how much of that is really attributable to this change and not just noise). |
|
The tuple sums improvements are all very consistently great, though 😮 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a
RemoteFlowSourceperformance issue. This was particularly visible onfreeotp-ios, where evaluatingRemoteFlowSourcewas taking twice as long due to this part blowing up.Note that the case immediately above already has
pragmas like the ones I introduce.We should check DCA results before merging.