Skip to content

ATM: add boosted version for ShellCommandInjectionFromEnvironment JS query #11709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2023
Merged

ATM: add boosted version for ShellCommandInjectionFromEnvironment JS query #11709

merged 4 commits into from
Jan 20, 2023

Conversation

jhelie
Copy link
Contributor

@jhelie jhelie commented Dec 15, 2022 •
edited
Loading

This is now ready for review as the evaluation of the models using this query has proved satisfying.

edit: commit by commit review recommended.

@jhelie jhelie added the ATM label Dec 15, 2022
@jhelie jhelie force-pushed the jhelie/add-shell-command-injection branch from 335ea83 to c3da1b2 Compare December 16, 2022 16:35
@jhelie jhelie force-pushed the jhelie/add-shell-command-injection branch from 87b75a1 to 38c4a18 Compare December 19, 2022 10:14
@jhelie jhelie force-pushed the jhelie/add-shell-command-injection branch 3 times, most recently from 74b75c0 to 07ff2e4 Compare December 19, 2022 13:26
@jhelie jhelie force-pushed the jhelie/add-shell-command-injection branch from 7aa0f0a to fec7ea6 Compare January 17, 2023 11:21
@jhelie jhelie marked this pull request as ready for review January 20, 2023 13:51
@jhelie jhelie requested a review from a team January 20, 2023 13:51
TomBolton
TomBolton approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@TomBolton TomBolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Exciting to see a new query being added to ATM. I also appreciate how many files need updating to achieve this! Thanks for persisting.

(I realise the new query won't actually start getting used until we bump the QL SHA in main of the orchestrator state file)

@jhelie jhelie merged commit 9e6f9c2 into main Jan 20, 2023
@jhelie jhelie deleted the jhelie/add-shell-command-injection branch January 20, 2023 15:03
@jhelie jhelie changed the title ATM: add boosted version for ShellCommandInjectionFromEnvironment query ATM: add boosted version for ShellCommandInjectionFromEnvironment JS query Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@TomBolton TomBolton TomBolton approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ATM documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhelie @TomBolton