C#/Java: Re-factor provenance related predicates. #11721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharpjava/refactorprovenance
branch
from
2a6eff5 to
dc71e95
Compare
michaelnebel
added
the
no-change-note-required
|
DCA looks good! |
michaelnebel
force-pushed
the
csharpjava/refactorprovenance
branch
from
4d54063 to
a28249f
Compare
tamasvajk
previously approved these changes
Jan 11, 2023
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
Outdated
Show resolved
Hide resolved
michaelnebel
dismissed stale reviews from tamasvajk and atorralba
via
7e4f7a0
michaelnebel
force-pushed
the
csharpjava/refactorprovenance
branch
from
8a55f84 to
7e4f7a0
Compare
|
@tamasvajk : Could you take a quick look. The only change since last time is the change in the comment. |
tamasvajk
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we re-factor some of the predicates that is related to the provenance column in the MaD format. This is to avoid converting from string -> bool -> string in different layers of the code.