Swift: Add more path injection sinks #11742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atorralba
force-pushed
the
atorralba/swift/more-path-injection-sinks
branch
from
d6eea64 to
19f76c3
Compare
geoffw0
approved these changes
Jan 4, 2023
| NSString().write(toFile: remoteString, atomically: true, encoding: 0) // $ hasPathInjection=139 | ||
| let _ = NSKeyedUnarchiver().unarchiveObject(withFile: remoteString) // $ hasPathInjection=139 | ||
| let _ = ArchiveByteStream.fileStream(fd: remoteString as! FileDescriptor, automaticClose: true) // $ hasPathInjection=139 | ||
| ArchiveByteStream.withFileStream(fd: remoteString as! FileDescriptor, automaticClose: true) { _ in } // $ hasPathInjection=139 |
There was a problem hiding this comment.
Where is the implementation used by remoteString as! FileDescriptor?
There was a problem hiding this comment.
Do you mean the functions being called? They're stubbed here.
There was a problem hiding this comment.
I think it was the conversion from String (remoteString) to FileDescriptor (the argument type) that was puzzling me, I was expecting to see [stub] code for it somewhere. But I guess the test works...
There was a problem hiding this comment.
Yes, it's a forced cast to keep it simple. That would probably not work if the code was actually executed, but it should be good enough for the test.
atorralba
force-pushed
the
atorralba/swift/more-path-injection-sinks
branch
from
19f76c3 to
6b52c15
Compare
|
Had to rebase to fix conflicts with the GRDB PR. |
atorralba
force-pushed
the
atorralba/swift/more-path-injection-sinks
branch
from
6b52c15 to
c115a9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.