JS: Sanitizer for sanitizer(x) === true
#11769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
moreSan
branch
2 times, most recently
from
dd0eb73 to
24a0836
Compare
esbena
reviewed
Jan 10, 2023
| class BooleanLiteral extends @boolean_literal, Literal { } | ||
| class BooleanLiteral extends @boolean_literal, Literal { | ||
| /** Gets the value of this literal. */ | ||
| boolean getBoolValue() { if this.getRawValue() = "true" then result = true else result = false } |
There was a problem hiding this comment.
Maybe consider naming consistency with TypeInference.qll:
/** Gets the unique Boolean value that this node evaluates to, if any. */
boolean getTheBooleanValue() { ... }There was a problem hiding this comment.
getBoolValue is consistent with the predicate in YamlBool (In YAML.qll).
So I prefer to keep it as is.
aibaars
reviewed
Feb 14, 2023
| exists(EqualityTest test, BooleanLiteral bool | | ||
| this.asExpr() = test and | ||
| test.hasOperands(prev.asExpr(), bool) and | ||
| polarity = test.getPolarity().booleanXor(bool.getBoolValue()) |
There was a problem hiding this comment.
I'm not sure I understand the use of xor here.
There was a problem hiding this comment.
I need polarity to flip both if test flips and if bool flips.
xor always flips when one of it's inputs flip, that's why I'm using it.
Then I had to figure out whether I had to add a .booleanNot() to the output or not, and that was just done by testing.
|
There are some merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11667
The
appliesTochange didn't change the result of any tests, but that feels like a lucky coincidence (because the nodes wereinstanceof DataFlow::BarrierGuardNodeanyway).Evaluations were uneventful: