All: Remove omittable exists variables #11775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ATM
C#
C++
DataFlow Library
Go
Java
JS
Python
QL-for-QL
Ruby
Swift
labels
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
java/ql/integration-tests/all-platforms/kotlin/default-parameter-mad-flow/test.ql
Fixed
Show fixed
Hide fixed
atorralba
force-pushed
the
atorralba/all/omittable-exists
branch
2 times, most recently
from
222a44f to
1789f9d
Compare
atorralba
force-pushed
the
atorralba/all/omittable-exists
branch
2 times, most recently
from
4a9c7db to
dac25a5
Compare
erik-krogh
previously approved these changes
Jan 4, 2023
owen-mc
previously approved these changes
Jan 5, 2023
atorralba
dismissed stale reviews from owen-mc, erik-krogh, yoff, aibaars, michaelnebel, and geoffw0
via
f36e2cb
atorralba
force-pushed
the
atorralba/all/omittable-exists
branch
from
3d55c21 to
f36e2cb
Compare
atorralba
force-pushed
the
atorralba/all/omittable-exists
branch
from
f36e2cb to
5c388c5
Compare
|
Thank you all for the reviews! 🙇 I had to rebase to fix conflicts. We're still missing a Java review, but due to the size of this PR and the high chances of conflicts appearing again soon, I feel inclined to just merge. Could anyone re-approve? |
owen-mc
approved these changes
Jan 10, 2023
erik-krogh
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unneeded exists variables, as described in the QL-for-QL query created in #11770.