Skip to content

Conversation

saritai
Copy link
Contributor

@saritai saritai commented Jan 6, 2023

This pull request adds docs for CodeQL pack compatibility as part of CodeQL CLI 2.12.0 release.

cc @hmakholm @felicitymay

@saritai saritai requested a review from a team as a code owner January 6, 2023 16:18
@saritai saritai added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Jan 6, 2023
Copy link
Contributor

@hmakholm hmakholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for content; I checked with #codeql-releases and they are okay with merging into the release branch too.

@saritai
Copy link
Contributor Author

saritai commented Jan 6, 2023

@hmakholm Thank you! I can merge it into the branch anytime - I might just wait till Monday morning during your working hours but let me know if it is preferred to do it today!

@hmakholm
Copy link
Contributor

hmakholm commented Jan 6, 2023

I think Monday is OK. We'll need to do a follow-up submodule bump in github/semmle-code afterwards, but that won't actually block the release.

@saritai
Copy link
Contributor Author

saritai commented Jan 6, 2023

@hmakholm Sounds good, thank you!! Apologies again for any inconvenience and appreciate the quick review 🙇‍♀️

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks as expected. Thanks 💖

@saritai saritai merged commit be06469 into codeql-cli-2.12.0 Jan 9, 2023
@saritai saritai deleted the saritai/pr/qlx branch January 9, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ready-for-doc-review This PR requires and is ready for review from the GitHub docs team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants