Skip to content

Update grammars #11856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 23, 2023
Merged

Update grammars #11856

merged 8 commits into from
Jan 23, 2023

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Jan 9, 2023

@github-actions github-actions bot added the Ruby label Jan 9, 2023
@aibaars aibaars force-pushed the update-grammars branch 3 times, most recently from d61e729 to c2eecc2 Compare January 10, 2023 14:40
@aibaars aibaars marked this pull request as ready for review January 11, 2023 11:49
@aibaars aibaars requested a review from a team as a code owner January 11, 2023 11:49
@aibaars aibaars force-pushed the update-grammars branch 3 times, most recently from 528aff4 to 0acf096 Compare January 12, 2023 10:09
@calumgrant calumgrant requested a review from hmac January 16, 2023 09:45
@hmac
Copy link
Contributor

hmac commented Jan 19, 2023

The change LGTM, but DCA reports an increased number of extraction errors for some projects, do you know why that is? (I can't figure out where to find the actual errors themselves)

@aibaars
Copy link
Contributor Author

aibaars commented Jan 20, 2023

@hmac The difference in error counts is due to files that already had parse errors reported on them previously, but now have some more. Likely the parser's error recovery is slightly different as a result of the grammar change.

Copy link
Contributor

@hmac hmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 in that case

@aibaars aibaars merged commit 9914824 into github:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants