JS: slightly broaden the regular expression that recognizes bad string-concats used as shell commands #11859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncats used as shell commands
esbena
reviewed
Jan 18, 2023
| @@ -93,7 +93,7 @@ module UnsafeShellCommandConstruction { | |||
| this = root.getALeaf() and | |||
| root = isExecutedAsShellCommand(DataFlow::TypeBackTracker::end(), sys) and | |||
| exists(string prev | prev = this.getPreviousLeaf().getStringValue() | | |||
| prev.regexpMatch(".* ('|\")?[0-9a-zA-Z/:_-]*") | |||
| prev.regexpMatch(".*\\s*('|\")?[0-9a-zA-Z/:_-]*") | |||
There was a problem hiding this comment.
Can you document the intention of this entire pattern?
I note that the \\s* term is dead* due to the greedy .*. Did you perhaps mean .*\\s+?
*: dotall makes a difference, but since there's no comment about newlines here, and the new test does not contain a newline either.
There was a problem hiding this comment.
I've realized that in generalizing the regular expression, I had created a regular expression that matched every string.
So I've removed the regular expression, and just have a exists(this.getPreviousLeaf().getStringValue()), which I think is a good solution.
esbena
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2022-25923: TP
Evaluation was unevenful.