Skip to content

Java: Update the Model Difference workflow to use the gh api. #11861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2023
Merged

Java: Update the Model Difference workflow to use the gh api. #11861

merged 1 commit into from
Jan 13, 2023

Conversation

michaelnebel
Copy link
Contributor

No description provided.

@michaelnebel michaelnebel force-pushed the java/testmodeldiff branch 4 times, most recently from 618a42d to 7d25cf8 Compare January 12, 2023 18:21
@github-actions github-actions bot added the Java label Jan 12, 2023
@michaelnebel michaelnebel changed the title Java: Dummy commit to trigger the Mad Model Diff action workflow. Java: Update the Model Difference workflow to use the gh api. Jan 12, 2023
@github-actions github-actions bot removed the Java label Jan 12, 2023
@michaelnebel michaelnebel marked this pull request as ready for review January 12, 2023 18:48
@michaelnebel michaelnebel requested a review from a team as a code owner January 12, 2023 18:48
aeisenberg
aeisenberg approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tamasvajk
tamasvajk approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@tamasvajk tamasvajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Unrelated to your changes, there are some missing artifacts mentioned on the workflow summary page: https://github.com/github/codeql/actions/runs/3905134834.

@michaelnebel
Copy link
Contributor Author

LGTM

Unrelated to your changes, there are some missing artifacts mentioned on the workflow summary page: https://github.com/github/codeql/actions/runs/3905134834.

Yes, that is because there are no differences in the models produced with the code in main and in this PR. If the diff is empty there is not produced an html file.
I have tested the PR with changes that should produce a diff and in that case the html artifacts will be uploaded.
Were you thinking about that we should look into avoiding the message when the diff is empty?

@michaelnebel michaelnebel merged commit 3b15f23 into github:main Jan 13, 2023
@michaelnebel michaelnebel deleted the java/testmodeldiff branch January 13, 2023 07:20
@tamasvajk
Copy link
Contributor

Were you thinking about that we should look into avoiding the message when the diff is empty?

If this is the expected behaviour and generally everybody know this, we can leave it as it is.

@michaelnebel
Copy link
Contributor Author

Were you thinking about that we should look into avoiding the message when the diff is empty?

If this is the expected behaviour and generally everybody know this, we can leave it as it is.

Then we should probably do something :-)
PR is up: #11881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

@tamasvajk tamasvajk tamasvajk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelnebel @tamasvajk @aeisenberg