QL/Ruby: include OS version in cache keys for Rust binaries #11877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
force-pushed
the
ql-ql-cross
branch
4 times, most recently
from
2053676 to
d5a0164
Compare
aibaars
force-pushed
the
ql-ql-cross
branch
6 times, most recently
from
489144f to
74a5b77
Compare
aibaars
changed the title
erik-krogh
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into problem with mismatching GLIBC versions due to binaries having been built with a newer OS version, stored in the cache, and later used from the cache on an older OS. This pull request should solve that issue by including the OS version in the cache keys.
@erik-krogh