C#: add --working-dir=. to pre-finalize #11893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
csharpIndexFiles
branch
from
323ea95 to
dcc1c3d
Compare
michaelnebel
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codeql database index-fileswill by default find all files within thesource-location-prefixas specified in the WIP database.If what you really want is to extract the files under the current working directory, then you need to specify
--working-dir=.".I think that is what you want, and it's also what the pre-finalize script for Go is doing.
I'm not sure how I would add a test for this.
I just fixed a related error in Ruby/QL: #11884, which is how I found this (by searching for other uses of
codeql database index-files).