Skip to content

Swift: Add RNCryptor sinks to swift/constant-password #11905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Jan 17, 2023

Add RNCryptor sinks to swift/constant-password. This change allows the query to find two results in DVIA-v2 (DCA should confirm).

@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Swift labels Jan 17, 2023
@geoffw0 geoffw0 requested a review from a team as a code owner January 17, 2023 12:09
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once DCA is happy!

@geoffw0
Copy link
Contributor Author

geoffw0 commented Jan 18, 2023

DCA is happy, and shows the two new alerts. 🎉

They are listed as 'unclassified', which means classification failed. I think that's just because they were tagged as swift/hardcoded-key rather than swift/constant-password. I will fix that today...

@geoffw0
Copy link
Contributor Author

geoffw0 commented Jan 18, 2023

I will fix that today...

... but the fix will be in the DCA repo. So I might as well merge this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants