Ruby: Model Sinatra #11954
Merged
Ruby: Model Sinatra #11954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Adds some very basic modeling of Sinatra applications. We recognise the `params` call in Sinatra routes as an HTTP request input access.
Comment on lines
171
to
175
| /** | ||
| * A summary for accessing a local variable in an ERB template. | ||
| * This is the second half of the modelling of the flow from the `locals` keyword argument to variables in the ERB template. | ||
| * The first half is modeled by `ErbLocalsSummary`. | ||
| */ |
Check warning
Code scanning / CodeQL
Misspelling
alexrford
approved these changes
Mar 15, 2023
| */ | ||
| class ErbLocalsHashSyntheticGlobal extends SummaryComponent::SyntheticGlobal { | ||
| private string id; | ||
| private MethodCall erbCall; |
There was a problem hiding this comment.
I'm assuming that making this an ErbCall leads to non-monotonic recursion problems?
| /** | ||
| * Like `Location.toString`, but displays the relative path rather than the full path. | ||
| */ | ||
| private string locationRelativePathToString(Location loc) { |
There was a problem hiding this comment.
Does using this instead of toString make a difference in practice, or is it more a case of neatness/readability of the synthetic global ID?
There was a problem hiding this comment.
I don't know if there's any performance difference or otherwise - I just liked having a slightly neater ID 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had hoped to catch a few more CVEs with this, but sadly they require a bit more in the way of modeling. Opening this for review now so others can build on it.