Swift: Modernize injection queries #11979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to fix the failing check and add a few more commits to this PR tomorrow... |
|
(checks are now passing, ready for review) |
MathiasVP
approved these changes
Jan 30, 2023
My initial thought was probably not, because this PR is not meant to be behaviour changing. But on the other hand there are several changes that could perhaps affect performance (also, someone saying we "probably" don't need a DCA run might be a good heuristic for when we do in fact need to do a DCA run)... |
|
DCA: a little bit more than the usual level of wobble, but it looks fine to me:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize the injection queries
swift/unsafe-webview-fetch,swift/sql-injectionandswift/unsafe-js-eval. The queries are now split into a minimalAbc.qlfile mostly containing metadata, anAbcQuery.qlllibrary containing the query logic (dataflow configuration in these cases) and anAbcExtensions.qllcontaining sources/sinks/etc that might be reusable. This layout makes it easier to extend, test and customize existing queries, and to share sources/sinks/etc between them.This change should not affect query results.