Skip to content

C#: Improvements to cs/useless-upcast #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2018

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Aug 30, 2018

Fixed a few false positives related to disambiguation of static calls. We already have a change note for this query, so not added.

@hvitved hvitved added this to the 1.18 milestone Aug 30, 2018
@hvitved hvitved requested a review from calumgrant August 30, 2018 13:25
@hvitved hvitved requested a review from a team as a code owner August 30, 2018 13:25
@xiemaisi
Copy link

xiemaisi commented Sep 3, 2018

This PR is tagged for 1.18 but targeted at master, not rc/1.18.

@hvitved hvitved changed the base branch from master to rc/1.18 September 3, 2018 07:26
Copy link
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. Remember to put in a release note.

@hvitved
Copy link
Contributor Author

hvitved commented Sep 4, 2018

Remember to put in a release note.

We already have a change note for this query, so not added.

@semmle-qlci semmle-qlci merged commit 6c1098d into github:rc/1.18 Sep 5, 2018
@hvitved hvitved deleted the csharp/query/useless-upcast branch September 5, 2018 07:39
aibaars added a commit that referenced this pull request Oct 14, 2021
AST: lambda and block bodies
smowton added a commit to smowton/codeql that referenced this pull request Dec 6, 2021
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants