Skip to content

Rename Query History Actions #12000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

Rename Query History Actions #12000

merged 1 commit into from
Feb 10, 2023

Conversation

norascheuch
Copy link
Contributor

The next version of the VS Code extension will rename some actions on the query history menu.

@norascheuch norascheuch requested a review from a team as a code owner January 26, 2023 16:41
@norascheuch norascheuch added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Jan 27, 2023
koesie10
koesie10 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we'll probably need to wait until the extension has been released before merging this.

felicitymay
felicitymay reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of the release schedule for the VS Code extension but agree that this should be merged to ensure that the changes are published at the right moment.

We update the docs for every CodeQL CLI release, publishing from the relevant release candidate branch.

felicitymay
felicitymay approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience with my misunderstanding @norascheuch.

This looks ready to merge when you have a date for the release.

@charisk
Copy link
Contributor

charisk commented Feb 8, 2023 •
edited
Loading

A new release was published on February the 3rd (https://github.com/github/vscode-codeql/releases/tag/v1.7.8), shall we merge this?

@felicitymay
Copy link
Contributor

A new release was published on February the 3rd (https://github.com/github/vscode-codeql/releases/tag/v1.7.8), shall we merge this?

If you merge this PR the updated articles will be published with the next release of the CodeQL CLI in about two weeks. Is that okay?

@charisk
Copy link
Contributor

charisk commented Feb 8, 2023

A new release was published on February the 3rd (https://github.com/github/vscode-codeql/releases/tag/v1.7.8), shall we merge this?

If you merge this PR the updated articles will be published with the next release of the CodeQL CLI in about two weeks. Is that okay?

That sounds good to me. @norascheuch, @koesie10?

@norascheuch norascheuch merged commit d55e9d5 into main Feb 10, 2023
@norascheuch norascheuch deleted the nora/update-query-history-actions branch February 10, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koesie10 koesie10 koesie10 approved these changes

@felicitymay felicitymay felicitymay approved these changes

Assignees
No one assigned
Labels
documentation ready-for-doc-review This PR requires and is ready for review from the GitHub docs team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@norascheuch @charisk @felicitymay @koesie10