Skip to content

Java: update package for QueryProducer sinks #12008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2023
Merged

Java: update package for QueryProducer sinks #12008

merged 3 commits into from
Jan 30, 2023

Conversation

jcogs33
Copy link
Contributor

@jcogs33 jcogs33 commented Jan 27, 2023 •
edited
Loading

Description

This PR updates the package for QueryProducer sinks to org.hibernate.query instead of org.hibernate.
According to the docs and the HibernateQueryProducer type in Hibernate.qll, the package for QueryProducer should be org.hibernate.query.
MRVA shows new results from the java/sql-injection query after this update is made.

Let me know if there is any reason why these should not be updated.

@jcogs33 jcogs33 marked this pull request as ready for review January 27, 2023 18:04
@jcogs33 jcogs33 requested a review from a team as a code owner January 27, 2023 18:04
atorralba
atorralba approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a really good catch @jcogs33! Thanks for fixing this.

@jcogs33 jcogs33 merged commit 7f6efae into github:main Jan 30, 2023
@jcogs33 jcogs33 deleted the jcogs33/update-queryproducer-package branch January 30, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@atorralba atorralba atorralba approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcogs33 @atorralba