C#/Java: Materialize sink/source/summary predicates to avoid bad join order. #12118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
java/telemetry/supported-external-api-sinks
onglopezGitHub/Android23
(database artifact found here: https://github.com/codeql-testing/glopezGitHub--Android23/actions/runs/4050012179)yielded a log containing:
To avoid the join to
getAnInput
before the filtering (sinkNode) we materialize the predicateisSink
(that is, addpragma[nomagic]
). We do the same forisSource
andhasSummary
as they could potentially exhibit the same issue. The same is done for C#.It turned out that after introducing the pragmas on the predicates mentioned above another bad join was introduced in the characteristic predicate for
TestLibrary
where the name of all elements were matched against the regexp before joining only with those elements that represented packages. This has also been fixed.