Add hasLocationInfo for Types
#12131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbg
previously approved these changes
Feb 8, 2023
|
The changes look fine, but it looks like they have made some of the tests fail and they might need updating as well. |
smowton
reviewed
Feb 9, 2023
go/ql/lib/semmle/go/Types.qll
Outdated
| dt.getType() = this and | ||
| // Note that if the type declaration isn't in the source that we have | ||
| // then we use a dummy location. | ||
| dt.hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn) |
There was a problem hiding this comment.
I think we need to explicitly return the dummy location when there isn't such a DeclaredType
It returns a dummy location except for named types with a type declaration in the source.
Note that go/ql/test/library-tests/semmle/go/Types/QualifiedNames.expected and go/ql/test/library-tests/semmle/go/Types/Types.expected gain two lines. In both cases this is because GenericArray and GenericSignature are each instantiated twice, so they appear with two different locations.
owen-mc
force-pushed
the
go/named-type-location
branch
from
03704a8 to
685b8b4
Compare
|
The original version was giving multiple locations for some types because it was giving the locations of type aliases as well. The refactoring seems to fix that, which is good as we don't want to get duplicate results. |
|
DCA it; otherwise lgtm |
|
@smowton The first DCA failed for unknown reasons, but the second seems absolutely uneventful, as I'd expect. |
smowton
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It returns a dummy location except for named types with a type declaration in the source.