-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Java: add ssrf models discovered with heuristics #12155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: add ssrf models discovered with heuristics #12155
Conversation
94bee1b
to
7510327
Compare
c57b8af
to
15a1cbb
Compare
1f4e6e6
to
dd21ccc
Compare
85191b6
to
e85ae83
Compare
…he.http.client.methods.HttpRequestBase.setURI instead
…l; resolve conflicts
…c.client5.http.classic.methods
…sting apache-http-5 stubs
686de32
to
523feab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started this review as if this PR was normal library modelling work (i.e. looking for both incorrect models and missing models), but I don't think that's the correct way to look at it, since you're adding only things found through heuristics.
So, consider my review to only have looked into correctness, but not completeness. With that in mind, this LGTM.
Also, I used
majorAnalysis
since this PR adds a lot of Apache HttpComponents version 5 models, but let me know if it should beminorAnalysis
instead.
The distinction is subtle in this case because this is a big, popular library, so I don't think it matters much, but I feel inclined to always consider modelling work as minorAnalysis
(unless we model something really fundamental, like the full JDK or a good part of it, that is virtually going to affect every analysis). I usually see majorAnalysis
reserved to deeper changes, like an overhaul of the dataflow library or similar "everyone is impacted" things.
Feel free to leave it as it is if you have a strong opinion though.
I don't have a strong opinion, so I've switched it to |
Description
org.apache.http.HttpRequest#setURI
since this model is a typo and is covered by the model fororg.apache.http.client.methods.HttpRequestBase#setURI
instead.io.netty.handler.codec.http.HttpRequest#setUri
to a sink model instead.Consideration
majorAnalysis
since this PR adds a lot of Apache HttpComponents version 5 models, but let me know if it should beminorAnalysis
instead.