Skip to content

Python/Ruby/JS Crypto: Add a few algorithms + block modes #12165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

RasmusWL
Copy link
Member

I have tried to add a few links to support the claim that these algorithms are strong/safe. It wasn't always super easy, so in some cases I have ended up just linking to the documentation of the cryptography Python package.

RasmusWL and others added 2 commits February 13, 2023 10:40
I have tried to add a few links to support the claim that these
algorithms are strong/safe. It wasn't always super easy, so in some
cases I have ended up just linking to the documentation of the
`cryptography` Python package.

Co-authored-by: REDMOND\brodes <brodes@microsoft.com>
@RasmusWL RasmusWL requested review from a team as code owners February 13, 2023 09:45
@RasmusWL RasmusWL added the no-change-note-required This PR does not need a change note label Feb 13, 2023
tausbn
tausbn previously approved these changes Feb 13, 2023
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable to me. Thanks for linking to the relevant documentation! 👍

Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS 👍

Copy link
Contributor

@alexrford alexrford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby 👍

@RasmusWL RasmusWL merged commit c72dbc4 into github:main Feb 15, 2023
@RasmusWL RasmusWL deleted the crypto-updates branch February 15, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JS no-change-note-required This PR does not need a change note Python Ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants