JS: More precise type-test sanitizer guards in unsafe-html-construction #12177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
alias-html
branch
2 times, most recently
from
4bd36f4 to
8750a9b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
javascript/ql/lib/semmle/javascript/security/dataflow/UnsafeHtmlConstructionQuery.qll
Fixed
Show fixed
Hide fixed
erik-krogh
changed the title
erik-krogh
force-pushed
the
alias-html
branch
from
8750a9b to
fa125d4
Compare
erik-krogh
force-pushed
the
alias-html
branch
from
4111b36 to
b2fc3ac
Compare
erik-krogh
force-pushed
the
alias-html
branch
from
b2fc3ac to
9b308b2
Compare
… their properties are not
erik-krogh
force-pushed
the
alias-html
branch
from
9b308b2 to
51ddb55
Compare
erik-krogh
changed the title
|
Had to do a merge to fix a conflict in an expected file. |
alexrford
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2021-32850: TP
CVE-2022-30241: TP
CVE-2021-32860: TP
CVE-2021-41183: TP
The
TypeTestSanitizerwas a bit aggresive, it removed a bunch of TPs.This PR makes the modelling of objects more precise in the unsafe-html-construction query.
Evaluation was uneventful.