Go: Upgrade extractor compiler and dependency versions #12188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
force-pushed
the
smowton/feature/go-1.20-support
branch
from
3fc78cb to
d075e01
Compare
Some diagnostics have been reworded for Go 1.20, and a standard library type parameter is visible to the TypeParamType test.
owen-mc
approved these changes
Feb 15, 2023
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.19 | ||
| go-version: 1.20.0 |
There was a problem hiding this comment.
Is it worth using 1.20.x instead, so that we automatically get patch versions? I'm not aware of there ever being anything in a patch version which we've had to model.
owen-mc
reviewed
Feb 15, 2023
| @@ -13,3 +13,4 @@ | |||
| | TG2 | interface { } | | |||
| | U | interface { } | | |||
| | V | interface { int64 \| float64 } | | |||
| | bytes | interface { []uint8 \| string } | | |||
There was a problem hiding this comment.
I guess this is coming from a new library function?
There was a problem hiding this comment.
It appears that way, yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to Go 1.20, and upgrade the Go extractor's dependencies to their latest versions.