C#: Add an integration test which uses MSBuild #12196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
reviewed
Feb 15, 2023
| @@ -0,0 +1,4 @@ | |||
| from create_database_utils import * | |||
|
|
|||
| # force CodeQL to use MSBuild by setting `LGTM_INDEX_MSBUILD_TARGET` | |||
There was a problem hiding this comment.
We will soon get rid of the LGTM_ env variables, so it would be better not to rely on them. It would be better to create a .NET Classic project, as the auto builder will then use msbuild instead of dotnet build.
There was a problem hiding this comment.
I tried that first, but I couldn't get it to work because dotnet doesn't support .NET classic. So then we need mono instead on macOS and that doesn't provide msbuild on arm64.
There was a problem hiding this comment.
OK, let's do this for now then.
hvitved
previously approved these changes
Feb 16, 2023
mbg
force-pushed
the
mbg/csharp/add-msbuild-integration-tests
branch
from
7aed9a1 to
9db1366
Compare
|
@hvitved it looks like the CI was failing to Linux/Windows because Mono (used for |
hvitved
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an integration test for C# which uses MSBuild.