CI: inline the move-caches script into the action #12213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How is that currently broken? |
The |
kaeluka
approved these changes
Feb 16, 2023
Comment on lines
+51
to
+57
| // # Move all the existing cache into another folder, so we only preserve the cache for the current queries. | ||
| // mkdir -p ${COMBINED_CACHE_DIR} | ||
| // rm -f **/.cache/{lock,size} # -f to avoid errors if the cache is empty. | ||
| // # copy the contents of the .cache folders into the combined cache folder. | ||
| // cp -r **/.cache/* ${COMBINED_CACHE_DIR}/ || : # ignore missing files | ||
| // # clean up the .cache folders | ||
| // rm -rf **/.cache/* |
There was a problem hiding this comment.
delete?
Suggested change
| // # Move all the existing cache into another folder, so we only preserve the cache for the current queries. | |
| // mkdir -p ${COMBINED_CACHE_DIR} | |
| // rm -f **/.cache/{lock,size} # -f to avoid errors if the cache is empty. | |
| // # copy the contents of the .cache folders into the combined cache folder. | |
| // cp -r **/.cache/* ${COMBINED_CACHE_DIR}/ || : # ignore missing files | |
| // # clean up the .cache folders | |
| // rm -rf **/.cache/* |
| @@ -5,13 +5,6 @@ on: | |||
| branches: [main] | |||
| pull_request: | |||
| branches: [main] | |||
| paths: | |||
There was a problem hiding this comment.
I wanted to trigger QL-for-QL on this PR.
The simplest approach was just to always run QL-for-QL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way the action also works when used by another repository that includes
github/codeqlas a submodule.And a drive-by change that enforces that we always run QL-for-QL.