C# 11: Support for file scoped types.
#12234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/filescopedtypes
branch
from
33d6919 to
35793b4
Compare
|
DCA looks good. |
mbg
previously approved these changes
Feb 27, 2023
There was a problem hiding this comment.
This looks reasonable to me, especially after reviewing this commit-by-commit. Initially, trying to understand the refactoring from 8b967f9 combined with the other changes was a bit tricky.
Just one small comment about something I couldn't understand from the context of the other changes in this PR.
…bility extraction for file scoped types.
mbg
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we make support for
filescoped types. These types are only visible in the file where they are declared.