Skip to content

Swift: Taint sources for FileManager #12250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2023
Merged

Swift: Taint sources for FileManager #12250

merged 2 commits into from
Feb 20, 2023

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Feb 17, 2023

Taint source models for the FileManager class.

@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Swift labels Feb 17, 2023
@geoffw0 geoffw0 requested a review from a team as a code owner February 17, 2023 21:05
MathiasVP
MathiasVP approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Unrelated: Do you know why we've not made these tests inline expectations tests?

@geoffw0
Copy link
Contributor Author

geoffw0 commented Feb 20, 2023

Do you know why we've not made these tests inline expectations tests?

They would work better as inline expectations. I'll see if I can fit that in today (in a new PR that is).

@MathiasVP MathiasVP merged commit 49be5fd into github:main Feb 20, 2023
@geoffw0
Copy link
Contributor Author

geoffw0 commented Feb 20, 2023

Follow-up for inline expectations: #12263

@geoffw0 geoffw0 deleted the filemanagersource branch March 31, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffw0 @MathiasVP