C#/Java: Re-factor the isSupported predicate.
#12261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharpjava/refactorissupported
branch
from
b709709 to
86888b8
Compare
|
DCA looks good, except there seems to be an issue with a C# project that doesn't build anymore (this is also an issue in another DCA run). |
michaelnebel
added
the
no-change-note-required
aschackmull
previously approved these changes
Feb 21, 2023
mbg
previously approved these changes
Feb 21, 2023
| /** Holds if this API is a known neutral. */ | ||
| pragma[nomagic] | ||
| predicate isNeutral() { this instanceof FlowSummaryImpl::Public::NeutralCallable } | ||
|
|
||
| /** Holds if this API is supported by existing CodeQL libraries, that is, it is either a recognized source or sink or has a flow summary. */ |
There was a problem hiding this comment.
Should this comment be updated to reflect the additional condition?
There was a problem hiding this comment.
Yes, definitely! Thank you!
mbg
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that all uses of
isSupportedalso includes logic to cater for neutrals. In this PR we put this into theisSupportedpredicate itself.Thank you @starcke!