Skip to content

QL: Make the JSON parser a bit more robust #12280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

QL: Make the JSON parser a bit more robust #12280

merged 1 commit into from
Feb 22, 2023

Conversation

tausbn
Copy link
Contributor

@tausbn tausbn commented Feb 22, 2023

Updates the grammar to allow trailing commas in objects and arrays.

Also bumps the file size limit to 10MB.

@tausbn
QL: Make the JSON parser a bit more robust
2cdec47 
Updates the grammar to allow trailing commas in objects and arrays.

Also bumps the file size limit to 10MB.
@tausbn tausbn requested a review from MathiasVP February 22, 2023 13:48
@tausbn tausbn requested a review from a team as a code owner February 22, 2023 13:48
MathiasVP
MathiasVP approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MathiasVP MathiasVP merged commit 5e3289a into main Feb 22, 2023
@MathiasVP MathiasVP deleted the tausbn/ql-make-json-parsing-a-bit-more-robust branch February 22, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
QL-for-QL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tausbn @MathiasVP