Skip to content

Java: Add new java.net.URL taintsteps #12305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Java: Add new java.net.URL taintsteps #12305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1d765a
Missing taintstep for java.net.URL.toURI()
Feb 24, 2023
f393a3c
Add toExternalForm
Feb 24, 2023
4a9f63e
Fix toASCIIString casing
atorralba Feb 27, 2023
c027e10
Add java.net tests
atorralba Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion java/ql/lib/ext/java.net.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ extensions:
data:
- ["java.net", "URI", False, "URI", "(String)", "", "Argument[0]", "Argument[-1]", "taint", "manual"]
- ["java.net", "URI", False, "create", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
- ["java.net", "URI", False, "toAsciiString", "", "", "Argument[-1]", "ReturnValue", "taint", "manual"]
- ["java.net", "URI", False, "toASCIIString", "", "", "Argument[-1]", "ReturnValue", "taint", "manual"]
- ["java.net", "URI", False, "toString", "", "", "Argument[-1]", "ReturnValue", "taint", "manual"]
- ["java.net", "URI", False, "toURL", "", "", "Argument[-1]", "ReturnValue", "taint", "manual"]
- ["java.net", "URL", False, "URL", "(String)", "", "Argument[0]", "Argument[-1]", "taint", "manual"]
- ["java.net", "URL", False, "toURI", "", "", "Argument[-1]", "ReturnValue", "taint", "manual"]
- ["java.net", "URL", False, "toExternalForm", "", "", "Argument[-1]", "ReturnValue", "taint", "manual"]
- ["java.net", "URLDecoder", False, "decode", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
99 changes: 99 additions & 0 deletions java/ql/test/library-tests/frameworks/jdk/java.net/Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
package generatedtest;

import java.net.URI;
import java.net.URL;
import java.net.URLDecoder;
import java.nio.charset.Charset;

// Test case generated by GenerateFlowTestCase.ql
public class Test {

Object source() {
return null;
}

void sink(Object o) {}

public void test() throws Exception {

{
// "java.net;URI;false;URI;(String);;Argument[0];Argument[-1];taint;manual"
URI out = null;
String in = (String) source();
out = new URI(in);
sink(out); // $ hasTaintFlow
}
{
// "java.net;URI;false;create;;;Argument[0];ReturnValue;taint;manual"
URI out = null;
String in = (String) source();
out = URI.create(in);
sink(out); // $ hasTaintFlow
}
{
// "java.net;URI;false;toASCIIString;;;Argument[-1];ReturnValue;taint;manual"
String out = null;
URI in = (URI) source();
out = in.toASCIIString();
sink(out); // $ hasTaintFlow
}
{
// "java.net;URI;false;toString;;;Argument[-1];ReturnValue;taint;manual"
String out = null;
URI in = (URI) source();
out = in.toString();
sink(out); // $ hasTaintFlow
}
{
// "java.net;URI;false;toURL;;;Argument[-1];ReturnValue;taint;manual"
URL out = null;
URI in = (URI) source();
out = in.toURL();
sink(out); // $ hasTaintFlow
}
{
// "java.net;URL;false;URL;(String);;Argument[0];Argument[-1];taint;manual"
URL out = null;
String in = (String) source();
out = new URL(in);
sink(out); // $ hasTaintFlow
}
{
// "java.net;URL;false;toExternalForm;;;Argument[-1];ReturnValue;taint;manual"
String out = null;
URL in = (URL) source();
out = in.toExternalForm();
sink(out); // $ hasTaintFlow
}
{
// "java.net;URL;false;toURI;;;Argument[-1];ReturnValue;taint;manual"
URI out = null;
URL in = (URL) source();
out = in.toURI();
sink(out); // $ hasTaintFlow
}
{
// "java.net;URLDecoder;false;decode;;;Argument[0];ReturnValue;taint;manual"
String out = null;
String in = (String) source();
out = URLDecoder.decode(in);
sink(out); // $ hasTaintFlow
}
{
// "java.net;URLDecoder;false;decode;;;Argument[0];ReturnValue;taint;manual"
String out = null;
String in = (String) source();
out = URLDecoder.decode(in, (Charset) null);
sink(out); // $ hasTaintFlow
}
{
// "java.net;URLDecoder;false;decode;;;Argument[0];ReturnValue;taint;manual"
String out = null;
String in = (String) source();
out = URLDecoder.decode(in, (String) null);
sink(out); // $ hasTaintFlow
}

}

}
Empty file added java/ql/test/library-tests/frameworks/jdk/java.net/test.expected
View file
Open in desktop
Empty file.
2 changes: 2 additions & 0 deletions java/ql/test/library-tests/frameworks/jdk/java.net/test.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
import java
import TestUtilities.InlineFlowTest