C++: Disable a bad standard order #12350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the only predicate in the use-use dataflow library that was flagged by Schack's regexp. Indeed, it looks like a true positive:
Notice that in the
[[[ SEMINAIVE VARIANT - STANDARD ORDER]]]
version of the predicate the#prev
predicate is used before joining with#prev_delta
(which doesn't happen in the[[[ SEMINAIVE VARIANT - ORDER UP TO SIZE 500000]]]
case). This means we keepSCAN
'ing all the previous iterations, resulting in unexpected quadratic complexity. After this PR we get:which doesn't contain the bad pattern 🎉.