C#: Improve the unsafe
predicate on Modifiable.
#12370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the
unsafe
keyword is discarded during compilation, which means that when extracting from referenced assemblies, we are not able to identify whether a member isunsafe
.The compiler requires methods, delegates and properties that make any use of pointer like types is declared unsafe.
As this might not be that relevant for our queries it is relevant for stub generation.
One example of a nasty delegate type declared in .NET Runtime (ie. a
delegate
with adelagate*
(function pointer) return type).