Skip to content

Go: Add more JWT sinks #12396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Apr 4, 2023
Merged

Go: Add more JWT sinks #12396

merged 1 commit into from Apr 4, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 3, 2023

This pull requests adds modelling for katras/iris/v12/middleware/jwt, katras/jwt and gogf/gf-jwt frameworks.

@ghost ghost self-requested a review as a code owner March 3, 2023 22:41
@github-actions github-actions bot added the Go label Mar 3, 2023
@ghost ghost mentioned this pull request Mar 3, 2023
2 tasks
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests. There are already some tests for this query at go/ql/test/experimental/CWE-321/ that you can add to.

@ghost
Copy link
Author

ghost commented Mar 19, 2023

@owen-mc Tests Added!

@ghost
Copy link
Author

ghost commented Mar 27, 2023

@owen-mc Any updates here?

I have updated the branch to the latest main.

Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a few small issues and then I'll approve.

This pull requests adds modelling for `katras/iris/v12/middleware/jwt`, `katras/jwt` and `gogf/gf-jwt` frameworks.
@ghost
Copy link
Author

ghost commented Mar 31, 2023

@owen-mc Changes done! PTAL.

@owen-mc owen-mc merged commit 00fd23d into github:main Apr 4, 2023
@ghost ghost deleted the GoJwtSignImprovements branch April 4, 2023 16:19
@ghost
Copy link
Author

ghost commented Apr 6, 2023

@owen-mc Thanks for the quick merge. Did you update the GHSL ticket with the query review?

@owen-mc
Copy link
Contributor

owen-mc commented Apr 7, 2023

@porcupineyhairs Yes, I have.

Thank you for this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants