-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Go: Add more JWT sinks #12396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go: Add more JWT sinks #12396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests. There are already some tests for this query at go/ql/test/experimental/CWE-321/
that you can add to.
@owen-mc Tests Added! |
@owen-mc Any updates here? I have updated the branch to the latest main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just a few small issues and then I'll approve.
This pull requests adds modelling for `katras/iris/v12/middleware/jwt`, `katras/jwt` and `gogf/gf-jwt` frameworks.
@owen-mc Changes done! PTAL. |
@owen-mc Thanks for the quick merge. Did you update the GHSL ticket with the query review? |
@porcupineyhairs Yes, I have. Thank you for this contribution. |
This pull requests adds modelling for
katras/iris/v12/middleware/jwt
,katras/jwt
andgogf/gf-jwt
frameworks.