Skip to content

Swift: add constructor flow #12415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 10, 2023
Merged

Swift: add constructor flow #12415

merged 7 commits into from
Mar 10, 2023

Conversation

rdmarsh2
Copy link
Contributor

@rdmarsh2 rdmarsh2 commented Mar 6, 2023

This adds flow from the final value of the self object within a constructor to the result of the constructor.

@rdmarsh2 rdmarsh2 requested a review from a team as a code owner March 6, 2023 20:48
@github-actions github-actions bot added the Swift label Mar 6, 2023
geoffw0
geoffw0 reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

We should probably run DCA on the PR before merging.

MathiasVP
MathiasVP reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Otherwise, I think this looks good (although I hope we can do the simplification I've suggested) once we have a successful DCA run.

@geoffw0
Copy link
Contributor

geoffw0 commented Mar 8, 2023

LGTM apart from a merge conflict. Note that the swift/ql/test/library-tests/dataflow/taint test directory was split a few days ago into swift/ql/test/library-tests/dataflow/taint/core and swift/ql/test/library-tests/dataflow/taint/libraries. If you merge main and run both of those tests, I think you should be good.

MathiasVP
MathiasVP reviewed Mar 8, 2023
View reviewed changes
MathiasVP
MathiasVP previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the merge conflict is resolved!

@MathiasVP
Copy link
Contributor

Just needs an autoformat now 🤞.

@MathiasVP MathiasVP merged commit ab58d4c into main Mar 10, 2023
@MathiasVP MathiasVP deleted the rdmarsh2/swift/constructor-flow branch March 10, 2023 23:16
@geoffw0
Copy link
Contributor

geoffw0 commented Mar 13, 2023

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 left review comments

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdmarsh2 @geoffw0 @MathiasVP