Dataflow: Remove revFlowAlias and revFlowApAlias predicates #12420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspersv
force-pushed
the
kaspersv/dataflow-remove-alias-preds
branch
from
b3400aa to
8674b75
Compare
kaspersv
force-pushed
the
kaspersv/dataflow-remove-alias-preds
branch
from
8674b75 to
7694b2f
Compare
kaspersv
force-pushed
the
kaspersv/dataflow-remove-alias-preds
branch
from
7694b2f to
9630feb
Compare
hvitved
reviewed
Mar 20, 2023
kaspersv
changed the title
hvitved
reviewed
Mar 20, 2023
hvitved
approved these changes
Mar 20, 2023
aschackmull
approved these changes
Mar 20, 2023
|
@hvitved DCA results are in. No evidence of join order regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove
revFlowAliasandrevFlowApAliaspredicates from the dataflow library. TherevFlowAliasandrevFlowApAliaspredicates were introduced to prevent the compiler from joining on constant node columns. With recent changes to the join ordering heuristic to avoid joins on constant columns, these alias predicates are no longer needed.