Dataflow: Instantiate stage 1 access paths with proper unit type #12421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspersv
changed the title
kaspersv
force-pushed
the
kaspersv/dataflow-proper-unit
branch
from
3b8596f to
ce6be1f
Compare
kaspersv
changed the title
aschackmull
approved these changes
Mar 23, 2023
hvitved
approved these changes
Mar 23, 2023
|
@aschackmull What is the procedure for merging PRs to the dataflow library? Can I go ahead and merge this now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR instantiates access paths for stage 1 of the dataflow library with a proper unit type. With recent changes to the join orderer to avoid joins on constant columns and DIL to RA term translation optimisations, the previous trick to prevent the optimiser from inferring that access paths were constant is no longer needed.
The initial Java DCA experiment showed a significant regression for
palatable__lambdabut it didn't reproduce in subsequent reruns.