Skip to content

C++: Fix asUninitialized #12432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MathiasVP
Copy link
Contributor

We've seen a number of weird results when using the IR version of the UninitializedNode class. This should hopefully fix the weirdness.

@MathiasVP MathiasVP requested a review from a team as a code owner March 7, 2023 16:20
@github-actions github-actions bot added the C++ label Mar 7, 2023
@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Mar 7, 2023
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MathiasVP
Copy link
Contributor Author

CI failures are unrelated. 🤠 merging!

@MathiasVP MathiasVP merged commit 8308c66 into github:mathiasvp/replace-ast-with-ir-use-usedataflow Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants