C++: Convert a number of data flow based queries to use ConfigSig
#12435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
approved these changes
Mar 7, 2023
jketema
commented
Mar 7, 2023
Apparently some queries we skipped in the testing I did locally.
MathiasVP
approved these changes
Mar 7, 2023
|
@MathiasVP Except for the caching issue DCA looks good. Should we hold this off, can we just merge? |
Hmm... I'd like to just merge it. It does put slightly more risk on the use-use flow branch for the upcoming LGTM run, but I don't think it's enough to be concerning. |
MathiasVP
merged commit e68bb53
into
github:mathiasvp/replace-ast-with-ir-use-usedataflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting the use-use dataflow feature branch, because I cannot be bothered to solve any merge conflicts when doing this on
main.