Skip to content

C++: Use getAUse in getIRRepresentationOfIndirectOperand #12465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

C++: Use getAUse in getIRRepresentationOfIndirectOperand #12465

merged 1 commit into from
Mar 9, 2023

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Mar 9, 2023 •
edited
Loading

Stop Howie, stop.

@jketema jketema changed the title C++: C++: Use getAUse in getIRRepresentationOfIndirectOperand C++: Use getAUse in getIRRepresentationOfIndirectOperand Mar 9, 2023
@github-actions github-actions bot added the C++ label Mar 9, 2023
@jketema jketema mentioned this pull request Mar 9, 2023
Merged
@jketema
Copy link
Contributor Author

jketema commented Mar 9, 2023

@MathiasVP DCA looks better than expected. There's one new result which seems legit and there's one result less, which seems some result duplication that is now gone. I do see a new FP on one of our internal tests, which we may need to look at.

@MathiasVP
Copy link
Contributor

MathiasVP commented Mar 9, 2023 •
edited by jketema
Loading

Indeed, DCA definitely seems to show that the lost results we're seeing on tests isn't common.

@jketema
Copy link
Contributor Author

jketema commented Mar 9, 2023 •
edited
Loading

How do we want to proceed? Accept the test change and merge?

@MathiasVP
Copy link
Contributor

MathiasVP commented Mar 9, 2023 •
edited by jketema
Loading

That sounds fine with me, yeah. Let's merge and create an issue for the bad test changes.

@jketema jketema added the no-change-note-required This PR does not need a change note label Mar 9, 2023
@jketema jketema marked this pull request as ready for review March 9, 2023 15:50
@jketema jketema requested a review from a team as a code owner March 9, 2023 15:50
MathiasVP
MathiasVP approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jketema jketema merged commit 13483be into github:mathiasvp/replace-ast-with-ir-use-usedataflow Mar 9, 2023
@jketema jketema deleted the get-a-use-2 branch March 9, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @MathiasVP