Skip to content

JS: fix NPE #12478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2023
Merged

JS: fix NPE #12478

merged 1 commit into from
Mar 10, 2023

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Mar 10, 2023

The extract method may return null:

  /** @return the number of lines of code extracted, or {@code null} if the file was cached */
  public ParseResultInfo extract(File f, ExtractorState state) throws IOException {

@aibaars aibaars requested a review from a team as a code owner March 10, 2023 11:58
@aibaars aibaars requested review from erik-krogh and removed request for a team March 10, 2023 11:58
@github-actions github-actions bot added the JS label Mar 10, 2023
@aibaars aibaars requested review from asgerf and removed request for erik-krogh March 10, 2023 12:03
asgerf
asgerf approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, though if any more errors pop up I think we should revert instead

@aibaars aibaars merged commit 7b8ac60 into github:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgerf asgerf asgerf approved these changes

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aibaars @asgerf