Ruby: Add some missing Rails sinks #12493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hmac
commented
Mar 12, 2023
hmac
commented
- Ruby: Add reorder as a SQL sink
- Ruby: Add count_by_sql as SQL sink
- Ruby: Taint flow through ActionController params
- Ruby: ActiveRecord::Connection.execute SQL sink
In recent versions of Rails this method doesn't seem to be vulnerable, but it may be in previous versions. There's a slight FP risk here, but I think it is small.
We were not recognising "require" as returning a Parameters instance.
asgerf
reviewed
Mar 13, 2023
Comment on lines
217
to
221
| exists(DataFlow::CallNode executeCall | | ||
| executeCall.getReceiver() = activeRecordConnectionInstance() and | ||
| executeCall.getMethodName() = "execute" and | ||
| this = executeCall.getArgument(0) and | ||
| unsafeSqlExpr(this.asExpr().getExpr()) |
There was a problem hiding this comment.
Suggested change
| exists(DataFlow::CallNode executeCall | | |
| executeCall.getReceiver() = activeRecordConnectionInstance() and | |
| executeCall.getMethodName() = "execute" and | |
| this = executeCall.getArgument(0) and | |
| unsafeSqlExpr(this.asExpr().getExpr()) | |
| this = activeRecordConnectionInstance().getAMethodCall("execute").getArgument(0) and | |
| unsafeSqlExpr(this.asExpr().getExpr()) |
We get more benefit from global flow if we stay at the level of API nodes as long as possible before lowering to data-flow nodes.
Comment on lines
228
to
231
| private DataFlow::Node activeRecordConnectionInstance() { | ||
| result = activeRecordClassApiNode().getAMethodCall("connection") | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| private DataFlow::Node activeRecordConnectionInstance() { | |
| result = activeRecordClassApiNode().getAMethodCall("connection") | |
| } | |
| private API::Node activeRecordConnectionInstance() { | |
| result = activeRecordClassApiNode().getReturn("connection") | |
| } |
alexrford
previously approved these changes
Mar 13, 2023
asgerf
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.