CPP: WrongTypeFormatArguments.ql Improvements #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmarsh2
reviewed
Apr 18, 2019
| @@ -1,5 +1,7 @@ | |||
| | tests.cpp:18:15:18:22 | Hello | This argument should be of type 'char *' but is of type 'char16_t *' | | |||
| | tests.cpp:19:15:19:22 | Hello | This argument should be of type 'char *' but is of type 'wchar_t *' | | |||
| | tests.cpp:21:15:21:21 | Hello | This argument should be of type 'char16_t *' but is of type 'char *' | | |||
| | tests.cpp:21:15:21:21 | Hello | This argument should be of type 'wchar_t *' but is of type 'char *' | | |||
There was a problem hiding this comment.
Do you know how this will render in LGTM? One message with two values, or two separate messages on the same line?
There was a problem hiding this comment.
On LGTM it'll be one alert with an expandable placeholder that says [ 2 values ]. Here's an example from a Java query.
jbj
added
the
depends on internal PR
geoffw0
force-pushed
the
wrongtypeformatmore
branch
from
645945b to
29f13fe
Compare
…ne possible expected argument type.
geoffw0
force-pushed
the
wrongtypeformatmore
branch
from
29f13fe to
1ee28fa
Compare
jbj
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing improvements to this query:
restrictqualified typesI,I32,I64andqlength specifiersI(see for example lines 2264, 2265 here: https://lgtm.com/projects/g/dotnet/coreclr/snapshot/3ba12824b9169f62223248deb26975fa0c4d27b1/files/src/gcinfo/gcinfoencoder.cpp?sort=name&dir=ASC&mode=heatmap#L2264)