Skip to content

add security-severity score to code scanning query list #12557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 30, 2024

Conversation

felickz
Copy link
Contributor

@felickz felickz commented Mar 16, 2023

Add security-severity metadata tag to the Build code scanning query list

Ex:
image

Sample from runs:

@felickz felickz marked this pull request as ready for review March 16, 2023 15:37
adityasharad
adityasharad previously approved these changes Aug 8, 2023
@RasmusWL
Copy link
Member

Let's look at getting this PR merged in the new year 😊

@felickz felickz requested a review from adityasharad January 17, 2024 14:25
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested changes so the new "Security score" column is added as the last column. This will make it easier if any script is reading the files using positional indexing.

(I personally don't know of any, but since I don't see any cost to doing this, I think we might as well play nice)

Ohterwise LGTM 👍

Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
@felickz
Copy link
Contributor Author

felickz commented Apr 16, 2024

I've suggested changes so the new "Security score" column is added as the last column. This will make it easier if any script is reading the files using positional indexing.

(I personally don't know of any, but since I don't see any cost to doing this, I think we might as well play nice)

Ohterwise LGTM 👍

Accepted and retested... looks good.

Sample from runs:

Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making this change 👍

@RasmusWL RasmusWL merged commit 377c6b4 into github:main Apr 30, 2024
@felickz felickz deleted the patch-1 branch August 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants