Skip to content

Java/C#: Validate all AccessPaths. #12610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Mar 21, 2023

In this PR we introduce validation for all accesspaths for all Java and C# models.
However, this comes at a cost. Both Java and C# validates Field and Property by checking whether the exist a Field or a Property that matches the accesspath - this validation will no longer be possible, if we want to validate all accesspaths.

@michaelnebel michaelnebel changed the title Java: Validate all AccessPaths. Java/C#: Validate all AccessPaths. Mar 22, 2023
@michaelnebel michaelnebel marked this pull request as ready for review March 22, 2023 10:38
@michaelnebel michaelnebel requested review from a team as code owners March 22, 2023 10:38
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Mar 22, 2023
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelnebel michaelnebel merged commit 915efff into github:main Mar 22, 2023
@michaelnebel michaelnebel deleted the java/validatespecs branch March 22, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants