Java/C#: Remove useless disjuncts. #12616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
atorralba
approved these changes
Mar 21, 2023
michaelnebel
approved these changes
Mar 22, 2023
hvitved
approved these changes
Mar 22, 2023
|
dca looks uneventful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of a long ought to always be convertible to a float, so that case does nothing (it's been around for a long time and git forensics indicate a possible cause, but it's not entirely clear).
The int case is also useless even though it isn't empty in the C# case, but in those cases (large unsigned ints) it is covered by
getNonIntegerValueand hence still irrelevant.