-
Notifications
You must be signed in to change notification settings - Fork 1.8k
C#: Improve cs/web/debug-binary to repect the RemoveAttributes transformation. #12648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Improve cs/web/debug-binary to repect the RemoveAttributes transformation. #12648
Conversation
cf4ca48
to
bc771e8
Compare
… projects and add some more tests.
88b48c2
to
4a64479
Compare
The DCA results show that we need to narrow the application of the transformation files to not miss any true positives. |
The DCA execution looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The issue that is referring this PR provides some more information.
Basically, we should disregard
debug=true
in case there exist a transformation that removes the debug attribute (a transformation file in the same folder as the Web.Config file).E.g. if there exist a transformation file with content like
then we can disregard
debug=true
in theWeb.config
file.According to Microsoft documentation the tag doesn't need to be under
system.web
.