C++: Add StrlenLiteralRangeExpr #12650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
previously approved these changes
Mar 24, 2023
MathiasVP
dismissed
their stale review
Oops. I forgot to say that this extension should also be imported in cpp/ql/lib/experimental/semmle/code/cpp/rangeanalysis/ExtendedRangeAnalysis.qll
gsingh93
force-pushed
the
strlen-literal-range-expr
branch
from
bf46946 to
67eb129
Compare
gsingh93
force-pushed
the
strlen-literal-range-expr
branch
from
67eb129 to
b87f12d
Compare
|
Fixed. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+4
to
+7
| /** | ||
| * Provides range analysis information for calls to `strlen` on literal strings. | ||
| * For example, the range of `strlen("literal")` will be 7. | ||
| */ |
Check warning
Code scanning / CodeQL
Class QLDoc style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While determining the range of the return value of
strlenis difficult in the general case, we can precisely and efficiently determine the range when the argument is a literal string. This extra precision can help reduce false positives in some queries.