-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Java: Move dataflow configurations in queries to *Query.qll
libraries (part 1)
#12681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
egregius313
merged 14 commits into
github:main
from
egregius313:egregius313/java/move-configurations-to-libraries
Mar 30, 2023
Merged
Java: Move dataflow configurations in queries to *Query.qll
libraries (part 1)
#12681
egregius313
merged 14 commits into
github:main
from
egregius313:egregius313/java/move-configurations-to-libraries
Mar 30, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
602b173
to
5b7b98c
Compare
*Query.qll
libraries*Query.qll
libraries (part 1)
47a5e45
to
ab15776
Compare
106114d
to
9afa051
Compare
atorralba
reviewed
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for doing this! I added a few comments.
java/ql/lib/change-notes/2023-03-29-moved-configurations-for-queries.md
Outdated
Show resolved
Hide resolved
java/ql/lib/semmle/code/java/security/ExternallyControlledFormatStringQuery.qll
Outdated
Show resolved
Hide resolved
java/ql/lib/semmle/code/java/security/InsecureBeanValidationQuery.qll
Outdated
Show resolved
Hide resolved
java/ql/lib/semmle/code/java/security/InsecureBeanValidationQuery.qll
Outdated
Show resolved
Hide resolved
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com>
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com>
Make some imports private Remove unnecessary imports
This class is used in the actual query, so it needs to be exposed.
atorralba
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the dataflow configurations and other classes defined in query files under
java/ql/src
to their own*Query.qll
libraries.