Skip to content

Java: Move dataflow configurations in queries to *Query.qll libraries (part 1) #12681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

egregius313
Copy link
Contributor

@egregius313 egregius313 commented Mar 27, 2023

Move the dataflow configurations and other classes defined in query files under java/ql/src to their own *Query.qll libraries.

@github-actions github-actions bot added the Java label Mar 27, 2023
@egregius313 egregius313 force-pushed the egregius313/java/move-configurations-to-libraries branch 2 times, most recently from 602b173 to 5b7b98c Compare March 28, 2023 19:29
@egregius313 egregius313 changed the title Java: Move dataflow configurations in queries to *Query.qll libraries Java: Move dataflow configurations in queries to *Query.qll libraries (part 1) Mar 29, 2023
@egregius313 egregius313 force-pushed the egregius313/java/move-configurations-to-libraries branch from 47a5e45 to ab15776 Compare March 29, 2023 18:43
@egregius313 egregius313 force-pushed the egregius313/java/move-configurations-to-libraries branch from 106114d to 9afa051 Compare March 29, 2023 22:00
@egregius313 egregius313 requested a review from atorralba March 30, 2023 02:49
@egregius313 egregius313 marked this pull request as ready for review March 30, 2023 02:50
@egregius313 egregius313 requested a review from a team as a code owner March 30, 2023 02:50
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this! I added a few comments.

egregius313 and others added 3 commits March 30, 2023 10:59
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com>
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com>
Make some imports private
Remove unnecessary imports
This class is used in the actual query, so it needs to be exposed.
@egregius313 egregius313 merged commit 8e54328 into github:main Mar 30, 2023
@egregius313 egregius313 deleted the egregius313/java/move-configurations-to-libraries branch March 30, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants